Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add turbo_stream.refresh builder method #595

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Add turbo_stream.refresh builder method #595

merged 1 commit into from
Sep 15, 2024

Conversation

seanpdoyle
Copy link
Contributor

Closes #579

Extends the turbo_stream tag builder helper to create <turbo-stream action="refresh"> elements through the pre-existing turbo_stream_refresh_tag method.

@seanpdoyle seanpdoyle mentioned this pull request Mar 3, 2024
Closed
@caleb caleb mentioned this pull request Mar 12, 2024
Open
@seanpdoyle seanpdoyle force-pushed the turbo_stream_refresh branch 2 times, most recently from f0ae535 to cea5764 Compare April 4, 2024 12:31
@OlegChuev
Copy link

Hi guys! Any updates/plans/ETA for this PR to be merged?

@radanskoric
Copy link

Would be nice to have this merged.

@radanskoric radanskoric mentioned this pull request Jun 10, 2024
Open
@rubiii
Copy link

rubiii commented Jun 30, 2024 •
edited
Loading

Anything we can do to help get this shipped?

@seanpdoyle seanpdoyle force-pushed the turbo_stream_refresh branch from cea5764 to 46d9d5b Compare July 13, 2024 09:57
@seanpdoyle seanpdoyle force-pushed the turbo_stream_refresh branch from 46d9d5b to 0833e18 Compare July 22, 2024 13:22
@seanpdoyle
Copy link
Contributor Author

@jorgemanrubia what do you think about expanding the Tag Builder interface to support [action="refresh"]?

@adrianthedev
Copy link

I was just looking for this method.
Not having it looks like the API is incomplete.
It forces devs to create turbo_stream.erb files instead of handling it in the controller.

@radanskoric
Copy link

I was just looking for this method. Not having it looks like the API is incomplete. It forces devs to create turbo_stream.erb files instead of handling it in the controller.

@adrianthedev, while I hope this gets merged soon, you can still do it in the controller:

respond_to do |format|
  format.turbo_stream { render turbo_stream: turbo_stream.action(:refresh, "") }
end

This is also useful if you have your own custom actions.

@radanskoric radanskoric mentioned this pull request Aug 21, 2024
Closed
@brendon
Copy link

brendon commented Aug 21, 2024

This would be great to have, though in my experience, adding the request-id means that the browser will ignore the refresh request (just like it ignores broadcast refresh requests with a matching request-id), or does this only apply to streamed refresh requests?

@seanpdoyle
Add turbo_stream.refresh builder method
ee5e1f5 
Closes [hotwired#579][]

Extends the `turbo_stream` tag builder helper to create `<turbo-stream
action="refresh">` elements through the pre-existing
`turbo_stream_refresh_tag` method.

[hotwired#579]: hotwired#579
@seanpdoyle seanpdoyle force-pushed the turbo_stream_refresh branch from 0833e18 to ee5e1f5 Compare August 29, 2024 17:21
@seanpdoyle
Copy link
Contributor Author

@jorgemanrubia @brunoprietog are either of you available to review this change?

@dhh dhh merged commit 9cd81b4 into hotwired:main Sep 15, 2024
15 checks passed
@seanpdoyle seanpdoyle deleted the turbo_stream_refresh branch September 15, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radanskoric radanskoric radanskoric approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refresh action is missing from Turbo::Streams::TagBuilder
7 participants
@seanpdoyle @OlegChuev @radanskoric @rubiii @adrianthedev @brendon @dhh